Skip to content

Update README to use implementation instead of compile - #461

Merged
thinkingserious merged 1 commit into
sendgrid:masterfrom
thatfiredev:update-readme
Oct 4, 2018
Merged

Update README to use implementation instead of compile#461
thinkingserious merged 1 commit into
sendgrid:masterfrom
thatfiredev:update-readme

Conversation

@thatfiredev

@thatfiredev thatfiredev commented Sep 30, 2018

Copy link
Copy Markdown
Contributor

Replace compile with implementation

We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines given above, then fill out the blanks below.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Replaces compile with implementation on the README.md

@thatfiredev
Update README.md
83c449a 
Replace compile with implementation
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 30, 2018
@SendGridDX

SendGridDX commented Sep 30, 2018 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@thatfiredev thatfiredev changed the title Use compile instead of implementation Update README to use implementation instead of compile Sep 30, 2018
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 2, 2018
@thinkingserious

thinkingserious commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

Hello @rosariopfernandes,

Could you please provide some background on why this change is necessary?

Thanks!

With Best Regards,

Elmer

@thatfiredev

thatfiredev commented Oct 2, 2018

Copy link
Copy Markdown
Contributor Author

(I'm sorry for quoting a post that quotes another doc, but I didn't find a better explanation)

According to this answer on StackOverflow, Gradle 3.0 had the compile configuration deprecated in favor of implementation and api. As mentioned in that answer:

Dependencies appearing in the api configurations will be transitively exposed to consumers of the library, and as such will appear on the compile classpath of consumers.

Dependencies found in the implementation configuration will, on the other hand, not be exposed to consumers, and therefore not leak into the consumers' compile classpath.

@thinkingserious

thinkingserious commented Oct 4, 2018

Copy link
Copy Markdown
Contributor

That makes sense @rosariopfernandes, thanks for the additional details!

@thinkingserious thinkingserious added hacktoberfest status: ready for deploy code ready to be released in next deploy and removed status: waiting for feedback waiting for feedback from the submitter labels Oct 4, 2018
@thinkingserious

thinkingserious commented Oct 4, 2018

Copy link
Copy Markdown
Contributor

Hello @rosariopfernandes,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
thinkingserious merged commit e90fd4a into sendgrid:master Oct 4, 2018
@thatfiredev

thatfiredev commented Oct 4, 2018

Copy link
Copy Markdown
Contributor Author

@thinkingserious I've filled the form. Thanks!

@thatfiredev
thatfiredev deleted the update-readme branch October 4, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thatfiredev @SendGridDX @thinkingserious